[webkit-reviews] review requested: [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached : [Attachment 16102] updated patch based on suggestions, also changed characters to keycodes

[bugzilla-daemon at webkit.org]

Jasper Bryant-Greene <m at ni.ac.nz> has asked  for review:
Bug 15057: EditorClientGtk is missing some important keypress handling, patch
attached
http://bugs.webkit.org/show_bug.cgi?id=15057

Attachment 16102: updated patch based on suggestions, also changed characters
to keycodes
http://bugs.webkit.org/attachment.cgi?id=16102&action=edit

------- Additional Comments from Jasper Bryant-Greene <m at ni.ac.nz>
Thanks for your suggestions. I've updated the patch based on them.

Also, I've changed the entries in keyEntries that were specified using a
character to keycodes, as the character doesn't work on GTK and I don't think
it would have worked on Qt either. For example 'X' has changed to VK_X.

I need verification that this specific change hasn't broken Windows keypress
handling, though.