[webkit-reviews] review denied: [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached : [Attachment 16087] updated patch to implement back/forward word/paragraph and home/end while selecting, and removed duplication

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 15057: EditorClientGtk is missing some important keypress handling, patch
attached
http://bugs.webkit.org/show_bug.cgi?id=15057

Attachment 16087: updated patch to implement back/forward word/paragraph and
home/end while selecting, and removed duplication
http://bugs.webkit.org/attachment.cgi?id=16087&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Okay, i think i agree with Adam's subsequent comment, I think we just need to
move WebView::interpretKeyEvent and WebView::handleEditingKeyboardEvent into
shared code... it might even be possible to move it into WebCore...
possibly in EventHandler surrounded by a #if !PLATFORM(MAC) block

So 
EventHandler::handleEditingKeyboardEvent(KeyboardEvent*) would do the current
WebView::handleEditingKeyboardEvent behaviour on all non-mac platforms.  and on
mac it would call the editing client