[webkit-reviews] review denied: [Bug 15057] EditorClientGtk is
missing some important keypress handling,
patch attached : [Attachment 16090] consolidates windows,
qt and gtk keypress handling
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 23 01:30:18 PDT 2007
Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 15057: EditorClientGtk is missing some important keypress handling, patch
attached
http://bugs.webkit.org/show_bug.cgi?id=15057
Attachment 16090: consolidates windows, qt and gtk keypress handling
http://bugs.webkit.org/attachment.cgi?id=16090&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
This needs to have a correct changelog for gtk
You also need to have correct copyright info in Editor{Mac}.cpp
Add that, and i would say it's an r+
However it will at least need to be tested on Mac and Webkit/Win prior to
landing.
I can do this tomorrow.
More information about the webkit-reviews
mailing list