[webkit-reviews] review denied: [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached : [Attachment 16086] updated patch with more keypress cases and a ChangeLog entry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 22 21:01:03 PDT 2007


Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 15057: EditorClientGtk is missing some important keypress handling, patch
attached
http://bugs.webkit.org/show_bug.cgi?id=15057

Attachment 16086: updated patch with more keypress cases and a ChangeLog entry
http://bugs.webkit.org/attachment.cgi?id=16086&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Looks fine, you might as well do the word/paragraph-fu though, and the
changelog should include the files/methods that are touched.

You should be able to just run the prepare-Changelog script and it should just
magically work



More information about the webkit-reviews mailing list