[webkit-reviews] review requested: [Bug 11011] External CSS is parsed as iso-8859-1 even though the main document is utf-8 : [Attachment 10851] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Sep 30 13:19:43 PDT 2006


Alexey Proskuryakov <ap at nypop.com> has asked  for review:
Bug 11011: External CSS is parsed as iso-8859-1 even though the main document
is utf-8
http://bugzilla.webkit.org/show_bug.cgi?id=11011

Attachment 10851: proposed fix
http://bugzilla.webkit.org/attachment.cgi?id=10851&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at nypop.com>
This fixes a bunch of cases; one loose end that might remain is handling of
dynamically modified stylesheets, e.g.:
s = document.implementation.createCSSStyleSheet(...);
s.insertRule('@charset ...', 0);
s.insertRule('@import...', 1);

However, I don't think the behavior in such cases is rigorously specified, and
testing to match other browsers seems infeasible (Firefox 1.5 doesn't even have
createCSSStyleSheet()).



More information about the webkit-reviews mailing list