[webkit-reviews] review granted: [Bug 11096] Hit testing for polylines fails : [Attachment 10846] First attempt

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Sep 30 06:21:32 PDT 2006

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 11096: Hit testing for polylines fails

Attachment 10846: First attempt

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Looks good.

But you need a better comment.	Here is a suggestion:

 // CGPathContainsPoint returns false for non-closed paths, as a work-around,
we copy and close the path first.  Radar 4758998 asks for a better CG API to

We could also consider only ever copying the path if CGPathContainsPoint
returns false.	I'm just not sure how expensive CGPathContainsPoint is relative
to a malloc.

More information about the webkit-reviews mailing list