[webkit-reviews] review granted: [Bug 11011] External CSS is parsed as iso-8859-1 even though the main document is utf-8 : [Attachment 10851] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Sep 30 13:49:25 PDT 2006


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11011: External CSS is parsed as iso-8859-1 even though the main document
is utf-8
http://bugzilla.webkit.org/show_bug.cgi?id=11011

Attachment 10851: proposed fix
http://bugzilla.webkit.org/attachment.cgi?id=10851&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+#include "CSSCharsetRule.h"

Why is this additional include needed in CSSStyleSheet.cpp?

+StyleSheet *StyleSheetList::item(unsigned index)

Should move the * to the left too while we're at it.

+	     c->setCSSStyleSheet(String(ResponseURL(m_response)),
m_decoder->encoding().name(), m_sheet);

Do we really need the explicit String() here?

r=me



More information about the webkit-reviews mailing list