[webkit-reviews] review denied: [Bug 10684] Auto-generate the Objective-C DOM CSS bindings : [Attachment 10357] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Sep 1 19:38:14 PDT 2006

Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 10684: Auto-generate the Objective-C DOM CSS bindings

Attachment 10357: patch

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Looking good.

Some comments before I r+ this:

Double ChangeLog entry.

+//- (NSString *)description
+//    return [NSString stringWithFormat:@"DOMCSSStyleDeclaration: %@", [self

That should be removed. We can add back in descriptions per-class if we feel
they are needed.

@interface DOMDocument (DOMViewCSS)
 - (DOMCSSStyleDeclaration *)getComputedStyle:(DOMElement *)elt :(NSString

Can that be moved to another headers? DOMExtensions.h?

More information about the webkit-reviews mailing list