[webkit-reviews] review denied: [Bug 10684] Auto-generate the Objective-C DOM CSS bindings : [Attachment 10357] patch

[bugzilla-request-daemon at opendarwin.org]

Timothy Hatcher <timothy at hatcher.name> has denied Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 10684: Auto-generate the Objective-C DOM CSS bindings
http://bugzilla.opendarwin.org/show_bug.cgi?id=10684

Attachment 10357: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10357&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Looking good.

Some comments before I r+ this:

Double ChangeLog entry.

+//- (NSString *)description
+//{
+//    return [NSString stringWithFormat:@"DOMCSSStyleDeclaration: %@", [self
cssText]];
+//}  

That should be removed. We can add back in descriptions per-class if we feel
they are needed.

@interface DOMDocument (DOMViewCSS)
 - (DOMCSSStyleDeclaration *)getComputedStyle:(DOMElement *)elt :(NSString
*)pseudoElt;
 @end

Can that be moved to another headers? DOMExtensions.h?