[webkit-reviews] review denied: [Bug 7227] REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab : [Attachment 6443] patch

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has denied Vicki Murley <vicki at apple.com>'s
request for review:
Bug 7227: REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order
differs for mouse click and tab
http://bugzilla.opendarwin.org/show_bug.cgi?id=7227

Attachment 6443: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6443&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
 static_cast<QLineEdit*>(oldFocusWidget)->edited()

Isn't this unsafe when the widget isn't actually a QLineEdit? I don't see the
code checking for this. I think you need to check. Other than that, looks like
a good fix.