[webkit-reviews] review requested: [Bug 7227] REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab : [Attachment 6443] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Feb 12 18:42:15 PST 2006


Vicki Murley <vicki at apple.com> has asked  for review:
Bug 7227: REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order
differs for mouse click and tab
http://bugzilla.opendarwin.org/show_bug.cgi?id=7227

Attachment 6443: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6443&action=edit

------- Additional Comments from Vicki Murley <vicki at apple.com>
Here's a possible fix.	I'm not sure if this is the best way to check for
whether a node is a textfield/textarea, or if there is an easier way to see if
the node has been edited.  Basically I just looked at what was being checked in
handleFocusOut for these two kinds of elements, then performed those same
checks when resigning focus from the old node in setFocusNode.	Looking forward
to some feedback.



More information about the webkit-reviews mailing list