[webkit-reviews] review requested: [Bug 5146] max-height/max-width not resizing images with correct aspect ratio : [Attachment 6447] patch 3

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Feb 12 20:35:18 PST 2006

Sam Weinig <sam.weinig at gmail.com> has asked  for review:
Bug 5146: max-height/max-width not resizing images with correct aspect ratio

Attachment 6447: patch 3

------- Additional Comments from Sam Weinig <sam.weinig at gmail.com>
This patch fixes all the issues the last one had by adding a change to the
calcMinMaxWidth() function in RenderReplaced that I forgot in the previous one.
 I should note that this patch does not add correct functionality for max/min
height/width for absolutly positioned images, but it also has no negative
affect on absolutly position element either.  The code for absolutly positioned
element is handled a little different and as it stands is quite messy.	In fact
most of RenderBox up through RenderReplaced and RenderImage could use some love
as the code paths are quite unclear at best.

More information about the webkit-reviews mailing list