[webkit-reviews] review denied: [Bug 5256] Relayout during load
causes duplicate plugin part :
[Attachment 4267] don't update widget until OBJECT tag is closed
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Oct 9 13:41:13 PDT 2005
Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 5256: Relayout during load causes duplicate plugin part
http://bugzilla.opendarwin.org/show_bug.cgi?id=5256
Attachment 4267: don't update widget until OBJECT tag is closed
http://bugzilla.opendarwin.org/attachment.cgi?id=4267&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Looks pretty good. I suggest that allParamsAvailable() be a const member
function. Also, I think it should be inline since it's just getting the value
of a boolean field. Also, I see no reason for it to be virtual.
How does this work in the case where you dynamically create an object element
and add parameter elements one by one? Or does that not need to work?
More information about the webkit-reviews
mailing list