[webkit-reviews] review denied: [Bug 5257] setYear() does not match FireFox/IE behavior : [Attachment 4193] Suggested patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Oct 9 14:06:09 PDT 2005

Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 5257: setYear() does not match FireFox/IE behavior

Attachment 4193: Suggested patch

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think it's a mistake to call fillStructures..., since that function parses
optional month and day arguments, which aren't valid in a setYear call. (That's
the cause for the r-.) 

I'm also not clear how this solves the 18XX case, since fillStructures... will
set tm_year to y - 1900 (a negative number).

Finally, it would be neat if you made this change in Date::construct() and
Date::callAsFunction, since they have the same problem.

More information about the webkit-reviews mailing list