[webkit-reviews] review denied: [Bug 3244] Support the 'label'
element in HTML forms :
[Attachment 3799] Proposed patch for the partial implementation of LABEL
element support
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Oct 9 13:39:11 PDT 2005
Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3244: Support the 'label' element in HTML forms
http://bugzilla.opendarwin.org/show_bug.cgi?id=3244
Attachment 3799: Proposed patch for the partial implementation of LABEL element
support
http://bugzilla.opendarwin.org/attachment.cgi?id=3799&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
HTMLInputElementImpl* is incorrect formatting. There's spposed to be a space
before the *.
I don't undersand the purpose of this line of code:
+ inputElt->setChecked(inputElt->checked());
Also, there should not be braces around single-line if statements.
Otherwise, this looks like a good start; I think the basic approach is pretty
good. Please do add a test and keep working on it!
More information about the webkit-reviews
mailing list