[webkit-reviews] review denied: [Bug 3539] WebKit JavaScript Does not Properly Support Circular References : [Attachment 2649] Patch to match behaviour of firefox and IE

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 3539: WebKit JavaScript Does not Properly Support Circular References
http://bugzilla.opendarwin.org/show_bug.cgi?id=3539

Attachment 2649: Patch to match behaviour of firefox and IE
http://bugzilla.opendarwin.org/attachment.cgi?id=2649&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks like this is on the right track.

Formatting is not really right
<http://webkit.opendarwin.org/coding/coding-style.html>.

Before landing this, we need to figure out exactly which tests to land with it;
at the moment there are lots of different tests attached to the bug and they
need to be put in layout test form.

I'm not comfortable with using a giant global array as part of the solution
here. I suggest we make a small fixed-size global array, then switch over to
using a hash table instead once we pass a certain recursion threshold to avoid
O(n^2) behavior. That also has the pleasant quality of making the global much
smaller.

Is it OK to share a single array between both Join and ToString? I'd like to
see a test that checks for that.