[webkit-reviews] review granted: [Bug 3733] Incorrect bidi layout of ETs, ANs, and ENs in some contexts : [Attachment 2668] Proposed fix

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 3733: Incorrect bidi layout of ETs, ANs, and ENs in some contexts
http://bugzilla.opendarwin.org/show_bug.cgi?id=3733

Attachment 2668: Proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=2668&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
With a sizable patch like this, it would be nice if the new code fit our coding
style guidelines <http://webkit.opendarwin.org/coding/coding-style.html>.

I don't think it's good style to leave behind commented-out lines of code.

That having been said, as long as the layout test results are still good, then
it seems fine to land this.

Unfortunately I don't know the concepts well enough to review this for real,
but I don't think any of the reviewers do at the moment.

I'd still very much like to see the version of this that makes fewer runs
landed eventually.