[webkit-reviews] review denied: [Bug 3539] WebKit JavaScript Does not Properly Support Circular References : [Attachment 2640] Patch to fix the *type* of error given to what it should be

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jun 27 17:25:02 PDT 2005


Darin Adler <darin at apple.com> has denied Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 3539: WebKit JavaScript Does not Properly Support Circular References
http://bugzilla.opendarwin.org/show_bug.cgi?id=3539

Attachment 2640: Patch to fix the *type* of error given to what it should be
http://bugzilla.opendarwin.org/attachment.cgi?id=2640&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks like a good change, but it's not formatted correctly. Please look at
<http://webkit.opendarwin.org/coding/coding-style.html>.

Also, it would be better if this patch had a separate bug report, and a test
case demonstrating it's fixed, rather than being part of the "does not support
circular references" bug.



More information about the webkit-reviews mailing list