[webkit-reviews] review denied: [Bug 3673] GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer : [Attachment 2577] Adds setBuffer() support and a QByteArray based constructor

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3673: GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer
http://bugzilla.opendarwin.org/show_bug.cgi?id=3673

Attachment 2577: Adds setBuffer() support and a QByteArray based constructor
http://bugzilla.opendarwin.org/attachment.cgi?id=2577&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Formatting of QBuffer::setBuffer does not match our coding guidelines. The "{"
should be on the line after the declaration, not on the same line. Also, the
"if (isOpen()) return false;" should be broken into two lines rather than
together on one.

Other than the coding guidelines issue, this looks great.