[webkit-reviews] review denied: [Bug 3672] GW: KWQRect -- CGRect and other small additions : [Attachment 2576] KWQRect -- CGRect and other small additions

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3672: GW: KWQRect -- CGRect and other small additions
http://bugzilla.opendarwin.org/show_bug.cgi?id=3672

Attachment 2576: KWQRect -- CGRect and other small additions
http://bugzilla.opendarwin.org/attachment.cgi?id=2576&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good. A few comments:

The QRect contructor that takes two points is too long to be inline. Please
move it into the .mm file.

Why did you make left() and top() non-inline? They shouldn't be changed unless
there's a reason.

In QRect::normalize, you should use "-w" rather than "(w * -1)" and "-h" rather
than "(h * -1)".

No need for the extra blank line after operator CGRect. Better to keep the
file's format consistent, even in such a trivial detail.