[webkit-reviews] review denied: [Bug 3674] GW: Add CGPoint and other small fixes to KWQPoint* : [Attachment 2578] Adds CGPoint support, as well as various other small fixes

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3674: GW: Add CGPoint and other small fixes to KWQPoint*
http://bugzilla.opendarwin.org/show_bug.cgi?id=3674

Attachment 2578: Adds CGPoint support, as well as various other small fixes
http://bugzilla.opendarwin.org/attachment.cgi?id=2578&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The operator * implementation does not match our coding style. The "{" should
be on a second line.

The implementation of isNull() has some extra punctuation and spaces in it.
Should just be "return xCoord == 0 && yCoord == 0;".

There are extra spaces in the setPoints call inside the QPointArray constructor
that takes a QRect. I know that matches the existing constructor, but it does
not match our coding cuidelines.

In QPointArray::copy, it would be better to use a static_cast rather than a
C-style cast.

The boundingRect and point functions have the "{" o the same line as the
function declaration, but it should be on the next line.

The call to QMemArray<QPoint>::at(index) inside QPointArray::point, should just
be a call to at(index).