[webkit-reviews] review denied: [Bug 4095] internal.cpp - provides Windows capabilities : [Attachment 3045] Adds Windows capabilities

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 4095: internal.cpp - provides Windows capabilities
http://bugzilla.opendarwin.org/show_bug.cgi?id=4095

Attachment 3045: Adds Windows capabilities
http://bugzilla.opendarwin.org/attachment.cgi?id=3045&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Windows code does not have spaces after commas -- it should.

Some places say "#if WIN32" and others say "#ifndef WIN32". We should be
consistent. Either "#ifdef WIN32" and "#ifndef WIN32" or "#if WIN32" and #if
!WIN32".

Is that #define _WIN32_WINNT 0x500 really the right thing to do? If so, please
add a comment explaining why.

It does not seem right to set NDEBUG in this file. We already set NDEBUG when
doing deployment builds.

The "#define copysign _copysign" line is strange enough that it needs a comment
about why it's there.