[webkit-reviews] review denied: [Bug 4094] UString for Windows compilation fixes : [Attachment 3044] Fixes UString for Windows

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 4094: UString for Windows compilation fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=4094

Attachment 3044: Fixes UString for Windows
http://bugzilla.opendarwin.org/attachment.cgi?id=3044&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I don't think a JavaScriptCore patch should use KWQ in the title.

As an aside: Isn't there some way to get the <stdint.h> on Windows? Maybe we
can put a file named "stdint.h" in the directory that defines the types?

Why the change from #ifdef to #if on HAVE_STRINGS_H and not on HAVE_STRING_H?

Maybe the HAVE_ICU stuff should go into config.h?

Why is the #include of <assert.h> inside an ifdef? That shouldn't be necessary.


I suggest we eliminate the use of MAX rather than defining it. There's only one
use of it in the file, and it's not standard. We could use the C++ std::max
instead.