[webkit-reviews] review denied: [Bug 4087] Fixes function.cpp for
Windows : [Attachment 3034] Enables ICU, etc..
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Jul 21 13:06:01 PDT 2005
Darin Adler <darin at apple.com> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 4087: Fixes function.cpp for Windows
http://bugzilla.opendarwin.org/show_bug.cgi?id=4087
Attachment 3034: Enables ICU, etc..
http://bugzilla.opendarwin.org/attachment.cgi?id=3034&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This HAVE_ICU logic should be moved to <config.h> so it doesn't have to be in
every single file.
In fact, I think we can just assume ICU -- we don't really need the non-ICU
code path in JavaScriptCore.
Either way, this patch should be fixed.
More information about the webkit-reviews
mailing list