[webkit-gtk] WebKit 2 search API proposal

[Carlos Garcia Campos]

El mié, 04-01-2012 a las 12:38 +0100, Sergio Villar Senin escribió:
> En 26/12/11 17:19, Martin Robinson escribiu:
> >>> - webkit_web_find_client_search (string, flags)
> >>>  + signals
> >>>    + found-string(string, match_count)
> >>>    + find-error(string)
> >>>    + matches-count(string, match_count)
> > 
> > I like the set of signals you've defined here, but perhaps the names
> > could be similar to the C API. For instance, consider:
> > 
> > * found-string
> > * failed-to-find-string
> > * counted-matches
> 
> Well I just tried to give it more gnomish names but I don't have a
> strong opinion here.
> 
> Anyway, I was wondering, since the WebKitFind object will wrap all the
> info related to the search I think we do not need any extra argument in
> the signals as the client will get the WebKitFind and could request the
> required info. We would need something like:
> 
> + webkit_find_get_search_string()
> + webkit_find_get_matches()
> 
> Opinions?

Agree.

-- 
Carlos Garcia Campos
http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20120104/04781a35/attachment.bin>