[webkit-efl] Few change suggestions in EFL port
Lucas De Marchi
lucas.demarchi at profusion.mobi
Mon Apr 23 06:28:33 PDT 2012
On Fri, Apr 20, 2012 at 9:36 AM, Tomasz Morawski <t.morawski at samsung.com> wrote:
> Thank you for your feedback.
>> Putting more emphasis on 6): what needs to be EFLish is only the public
>> API we are exposing to the users. For all the rest we should favor the
>> WebKit best practices. This will make reviewers life easier as mentioned.
>> New API's are coming, it's better decide on this ASAP. For the things
>> that are already on ewk_private.h, we can create a master bug to track
>> the refactoring. The good thing about this change is it should be
>> seamless to users of the public API.
> I think most of this change could be done without changes in public API.
> Anyway, this situation shows another issue here. Without deep investigation
> the end user of API doesn't know what headers belongs to public API and what
> files are used for internal implementation of EFL port only.
If it's internal header, don't install it.
> Currently, number of public header base on EWebKit file that includes the
> all header files that are exported to public API is only 13 files (with
> #include "ewk_auth.h"
> #include "ewk_contextmenu.h"
> #include "ewk_cookies.h"
> #include "ewk_frame.h"
> #include "ewk_history.h"
> #include "ewk_js.h"
> #include "ewk_main.h"
> #include "ewk_network.h"
> #include "ewk_security_policy.h"
> #include "ewk_settings.h"
> #include "ewk_view.h"
> #include "ewk_window_features.h"
> There is also 29 other files that are used for internal imlementation only.
> After adding more private files this number will be higher. What you thing
> about moving this files into other directory for example "src"?
We are already inside a directory named Source. Why another one? If
file doesn't contain "_internal.h" in the name, don't install it.
Morevover *don't* put struct declarations in public headers.
Lucas De Marchi
More information about the webkit-efl