[webkit-efl] Few change suggestions in EFL port

Tomasz Morawski t.morawski at samsung.com
Fri Apr 20 05:36:48 PDT 2012

Thank you for your feedback.

> Putting more emphasis on 6): what needs to be EFLish is only the public
> API we are exposing to the users. For all the rest we should favor the
> WebKit best practices. This will make reviewers life easier as mentioned.
> New API's are coming, it's better decide on this ASAP. For the things
> that are already on ewk_private.h, we can create a master bug to track
> the refactoring. The good thing about this change is it should be
> seamless to users of the public API.
I think most of this change could be done without changes in public API. 
Anyway, this situation shows another issue here. Without deep 
investigation the end user of API doesn't know what headers belongs to 
public API and what files are used for internal implementation of EFL 
port only.

Currently, number of public header base on EWebKit file that includes 
the all header files that are exported to public API is only 13 files 
(with EwebKit.h).

#include "ewk_auth.h"
#include "ewk_contextmenu.h"
#include "ewk_cookies.h"
#include "ewk_frame.h"
#include "ewk_history.h"
#include "ewk_js.h"
#include "ewk_main.h"
#include "ewk_network.h"
#include "ewk_security_policy.h"
#include "ewk_settings.h"
#include "ewk_view.h"
#include "ewk_window_features.h"

There is also 29 other files that are used for internal imlementation 
only. After adding more private files this number will be higher. What 
you thing about moving this files into other directory for example "src"?

Best Regards,
Tomasz Morawski

> Cheers,
> On Fri, Apr 20, 2012 at 10:59 AM, Tomasz Morawski
> <t.morawski at samsung.com <mailto:t.morawski at samsung.com>> wrote:
>     Hello,
>     I would like to ask if anyone have some comment about this topic?
>     Thank you,
>     Tomasz Morawski
>         Hello,
>         I would like to propose changes related to some aspect of c
>         programming
>         style used in our EFL WebKit port that could make our port more
>         consistent with other WebKit port like Gtk and Qt. Currently, we are
>         trying to follow some EFL libraries programming style that hides
>         structures declaration inside cpp files and use one single private
>         header file. I know that it works inside EFL's libraries but the our
>         WebKit port it is not and it will never be typical EFL's library. I
>         think current solution doesn't work well for example: overgrown
>         files
>         like ewk_view.h/cpp, ewk_frame.h/cpp files and ewk_private.h
>         file, a lot
>         of unneeded public API that is used only by internal WebKit
>         tools (like
>         DRT) but it will be never uses by final user. Moreover, there is
>         a lot
>         of programmers that would like to cleanup this mess and have more
>         readable port architecture.
>         I suggest to:
>         1) Allow to define ewk_*_private.h files when it is needed and
>         use it
>         internally like Gtk, Qt port does. It is possible to use
>         ewk_*_private.h
>         files by internal test application: the DRT tree or
>         other tests.
>         2) Move structures form cpp files to corresponding private
>         header files
>         (approach like Gtk and typical for c programming)
>         3) Move private function from ewk_private.h to corresponding private
>         header files and delete this file (more objective)
>         After that:
>         4) Simplify and remove some code that will be no need after this
>         refactor (some code is only for handling private by force
>         structures).
>         5) Reduce size of ewk_frame.h/cpp and ewk_view.h/cpp files by moving
>         some declaration to ewk_*_private.h
>         6) We will follow typical for WebKit's port architecture like
>         qt, gtk
>         port do (they use private file widely). Due to that the port code
>         organization will be more familiar for gtk reviewers and newcomer
>         programmer.
>         What you think about this?
>         Best Regards,
>         Tomasz Morawski
>         _________________________________________________
>         webkit-efl mailing list
>         webkit-efl at lists.webkit.org <mailto:webkit-efl at lists.webkit.org>
>         http://lists.webkit.org/__mailman/listinfo.cgi/webkit-__efl
>         <http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl>
>     _________________________________________________
>     webkit-efl mailing list
>     webkit-efl at lists.webkit.org <mailto:webkit-efl at lists.webkit.org>
>     http://lists.webkit.org/__mailman/listinfo.cgi/webkit-__efl
>     <http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl>

More information about the webkit-efl mailing list