[webkit-efl] ewk_view settings implementation
t.morawski at samsung.com
Fri Apr 13 00:50:34 PDT 2012
I also think that it is a great proposition of change that will simplify
use of API by end user (only two consistent functions to renember) and
reduce header code size. Personally, I don't like current settings API
that is just horrible for me. Yes, I also agree that it is not EFL API
style but good changes in API style that we are trying to introduce here
should by also considered by the EFL community too.
> Fully agree. But this is the api of Eina_Value which should be simplified.
I also agree, this should be changed.
Anyway, we will use Eina_Value in the near future in other parts of our
API also (please refer to bug:
https://bugs.webkit.org/show_bug.cgi?id=77337 and look at Comment #12
From Raphael Kubo da Costa (rakuco). Rapheal convince me to use
Eina_Value in API.) Now, I don't know why we should use Eina_Value for
js API but we should not use it for new setting API. This is not
consistent! If it is only case of initialization issue (2 steps) the API
of Eina_Value should be
fixed or we should accept this limitation and use it anyway.
> -----Original Message-----
> From: Rafael Antognolli [mailto:antognolli at profusion.mobi]
> Sent: Wednesday, April 11, 2012 6:09 PM
> To: Pozdnyakov, Mikhail
> Cc: Raphael Kubo da Costa; webkit-efl at lists.webkit.org
> Subject: Re: [webkit-efl] ewk_view settings implementation
> On Tue, Apr 10, 2012 at 4:56 AM, Pozdnyakov, Mikhail<mikhail.pozdnyakov at intel.com> wrote:
>>> Have you thought of using an enum instead for properties?
>> Fully agree, actually I am using enum in my patch already :)
>>> Bear in mind that you'll probably need to bump the Eina revision in jhbuild.modules if you do plan on using Eina_Value (and there's been no stable revision with it yet).
>> Thanks for the hint! Will try to figure out which is appropriate version.
> Hello all,
> As I already pointed out on bugzilla, I don't agree with this change.
> The API won't be much EFL-like, the code size of ewk_view.cpp won't necessarily be reduced (in fact, it can increase), and one will need 3 calls steps to change a setting:
> - setup of eina value;
> - setting of the value to this eina value;
> - call webkit setting API;
> This will reduce efficiency and increase the code needed to set one webkit-efl setting.
> Considering this, what's the big problem of keeping a function for each separate setting?
> Rafael Antognolli
> ProFUSION embedded systems
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
More information about the webkit-efl