[webkit-efl] ewk_view settings implementation

[Pozdnyakov, Mikhail]

Hello,

> code size of ewk_view.cpp won't necessarily be reduced
Think it will. Currently each of ewk_view_setting family functions
Contains:

EWK_VIEW_SD_GET_OR_RETURN(...)
EWK_VIEW_PRIV_GET_OR_RETURN(..)

When these functions will not have to be exported mentioned macros will be invoked only once from 
The common getter or setter function.

Here is a typical setting getter:

Eina_Bool ewk_view_setting_auto_shrink_images_get(const Evas_Object* o)
{
    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
    return priv->settings.auto_shrink_images;
}

If we do not have it exported and have only common getter instead, It will turn to just one line:
return priv->settings.auto_shrink_images;
Same with setters.

> one will need 3 calls steps to change a setting:
> - setup of eina value;
> - setting of the value to this eina value;
> - call webkit setting API;

Fully agree. But this is the api of Eina_Value which should be simplified. 
Think it should be possible to init an Eina_Value just for one call (now minimum 2 required).

BR,
Mikhail


-----Original Message-----
From: Rafael Antognolli [mailto:antognolli at profusion.mobi] 
Sent: Wednesday, April 11, 2012 6:09 PM
To: Pozdnyakov, Mikhail
Cc: Raphael Kubo da Costa; webkit-efl at lists.webkit.org
Subject: Re: [webkit-efl] ewk_view settings implementation

On Tue, Apr 10, 2012 at 4:56 AM, Pozdnyakov, Mikhail <mikhail.pozdnyakov at intel.com> wrote:
> Hi,
>
>> Have you thought of using an enum instead for properties?
> Fully agree, actually I am using enum in my patch already :)
>
>> Bear in mind that you'll probably need to bump the Eina revision in jhbuild.modules if you do plan on using Eina_Value (and there's been no stable revision with it yet).
> Thanks for the hint! Will try to figure out which is appropriate version.

Hello all,

As I already pointed out on bugzilla, I don't agree with this change.
The API won't be much EFL-like, the code size of ewk_view.cpp won't necessarily be reduced (in fact, it can increase), and one will need 3 calls steps to change a setting:

 - setup of eina value;
 - setting of the value to this eina value;
 - call webkit setting API;

This will reduce efficiency and increase the code needed to set one webkit-efl setting.

Considering this, what's the big problem of keeping a function for each separate setting?

Regards,
--
Rafael Antognolli
ProFUSION embedded systems
http://profusion.mobi
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.