[webkit-dev] DerivedSources.make: Another try?

[Patrick Gansterer]

On 16.03.2014, at 22:23, Darin Adler <darin at apple.com> wrote:

> 
> On Mar 16, 2014, at 2:19 PM, Patrick Gansterer <paroga at paroga.com> wrote:
> 
>> 
>> On 16.03.2014, at 22:08, Darin Adler <darin at apple.com> wrote:
>> 
>>> 
>>> What does shebang have to do with the makefile?
>> 
>> You can not run a script by "./script" on Windows and you need to invoke it with "perl ./script”
> 
> OK. Do we do that in DerivedSources.make? I couldn’t find any examples, but there might be some.

https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/DerivedSources.make?rev=165676#L77

>> E.g. at [1] the following line calls makeprop.pl with the --preprocessor argument "cl.exe /nologo /EP":
>> 
>> COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/css/makeprop.pl --defines "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}" --preprocessor "${CODE_GENERATOR_PREPROCESSOR}"
>> 
>> grep for CODE_GENERATOR_PREPROCESSOR in the CMakeLists.txt and *.cmake files should show up all other uses.
> 
> I see.
> 
> As I understand it, this is something we do in our CMake files. Not a feature of CMake, just something needed for the non-cygwin configuring on Windows that we only did to the CMake copy of the rules from DerivedSources.make, not to the original rules in DerivedSources.make.

Exactly. We need to extend DerivedSources.make files with this additional argument for the preprocessor. (the --preprocessor stuff was in the scripts before adding the CMake build system)

--
Patrick