[webkit-dev] Changes to main Frame creation in WebCore

[Brent Fulgham]

I can take care of this for the Windows ports. Can you cc me on the bug, please?

Thanks,

-Brent

Sent from my iPhone

On Aug 18, 2013, at 4:33 PM, Andreas Kling <akling at apple.com> wrote:

> Hello everyone!
> 
> Just a friendly heads-up that I’m planning to land some changes to the way main Frames are created in WebCore soon.
> 
> Previously, the WebKit layer would create a Frame with no owner element, and Frame::create() would implicitly tell Page that this is going to be the Page::mainFrame(). That mechanism leaves an awkward window in time where Page::m_mainFrame is null, and the goal here is to get rid of that by having Page construct the main Frame itself.
> 
> To do that, the Page constructor needs a FrameLoaderClient for the main Frame, in addition to all the other PageClients it already takes as an argument.
> 
> I have a patch here with WebKit1/mac and WebKit2 working, reviewed, and ready to rock: <https://webkit.org/b/119964>
> 
> Someone with know-how from WK1 ports will need to tweak the Page setup code in the relevant WebKit1 initialization function(s) to add a FrameLoaderClient to the PageClients passed to Page::Page(), and pick up the automatically created Page::mainFrame() instead of creating their own brand-new Frame and expecting it to become the main Frame.
> 
> Regards,
> Andreas
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20130818/a2c670c6/attachment.html>