[webkit-dev] do you want "WK1" and "WK2" keywords in the TestExpectations files?
ojan at chromium.org
Tue Nov 13 11:58:45 PST 2012
I don't have strong opinions on this, but one advantage of using the
keywords and getting rid of the dedicated TestExpectations files would be
to make the fallback graph actually be a tree instead of a DAG. This would
simplify the rebaselining tooling considerably and allow us to make a bunch
of cases work better that don't work great right now.
On Tue, Nov 13, 2012 at 11:41 AM, Dirk Pranke <dpranke at chromium.org> wrote:
> Hi all,
> I occasionally get asked if the TestExpectations syntax supports a way
> to distinguish different results for WebKit1 and WebKit2 via keywords.
> We currently don't do this, and different ports have worked around
> this in slightly different ways by using dedicated wk2-specific
> TestExpectations files and sometimes wk1-specific TestExpectations
> However, this is a little awkward and gets worse if you also need to
> support different expectations for multiple different configs (e.g.,
> mac-lion vs mac-snowleopard vs mac-mountainlion).
> So, it seems like WK1 and WK2 keywords might be useful. However, I
> don't really want to add more divergence between ports, so it would be
> nice to have everyone agree to use it if we were to add it.
> What do you all think? Would you like this feature, and would you all use
> it ?
> (Since I don't regularly switch between WK1 and WK2 I don't have a
> strong feeling here beyond what I've written above).
> -- Dirk
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev