[webkit-dev] About text decoration wavy style implementation on Skia platform

Lamarque Souza Lamarque.Souza at basyskom.com
Tue Nov 6 12:57:54 PST 2012


On November 5, 2012 at 7:27 PM Bruno Abinader <brunoabinader at gmail.com> wrote:

> 2012/11/5 Nico Weber <thakis at chromium.org [mailto:thakis at chromium.org] >
> > The spelling underline on OS X is not a wavy line. If you end up
> > changing the skia code, please make sure the chromium/mac spelling
> > underline doesn't become a wavy line.
> > 
> > Nico
> > 

> Interesting point. Said this, I'd say it is so far a matter of porting the
> drawErrorUnderline() code from Cairo/Qt into Skia and use it instead of
> modifying drawLineForDocumentMarker. For Qt/Cairo implementations, instead of
> duplicating code, just make use of the already implemented function with
> attention to use proper text decoration colors.
The attached patch replaces drawErrorUnderline() call in
drawLineForDocumentMarker() with a call to drawLine() using wavy stroke. The
patch is small and the result is pretty the same (I can attach the screenshots
if you want to see it). Please take a look.

Lamarque V. Souza
Software Engineer (basyskom.com)
Nokia Certified Qt Specialist
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121106/7cae7565/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drawErrorUnderline_wavy.diff
Type: text/x-patch
Size: 1572 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121106/7cae7565/attachment.bin>

More information about the webkit-dev mailing list