[webkit-dev] About text decoration wavy style implementation on Skia platform

Bruno Abinader brunoabinader at gmail.com
Mon Nov 5 10:27:18 PST 2012

2012/11/5 Nico Weber <thakis at chromium.org>

> The spelling underline on OS X is not a wavy line. If you end up
> changing the skia code, please make sure the chromium/mac spelling
> underline doesn't become a wavy line.
> Nico

Interesting point. Said this, I'd say it is so far a matter of porting the
drawErrorUnderline() code from Cairo/Qt into Skia and use it instead of
modifying drawLineForDocumentMarker. For Qt/Cairo implementations, instead
of duplicating code, just make use of the already implemented function with
attention to use proper text decoration colors.

Bruno de Oliveira Abinader
Software Engineer @ basysKom GmbH
WebKit committer / Nokia Certified Qt Specialist
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20121105/43c85363/attachment.html>

More information about the webkit-dev mailing list