[webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Benjamin Poulain benjamin at webkit.org
Wed May 16 23:33:21 PDT 2012

On Wed, May 16, 2012 at 11:04 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> { test: 'fast/html/keygen.html',
>>  platform: 'mac, linux',
>>  bug: 'webkit.org/b/66666',
>>  expectedResults: ['crash', 'text', 'image'],
>>  action: 'skip' }
> As far as I know, a lot of people edit this file on a text editor so the
> syntax needs be simple enough for that.

I do to, and it is why I split the dictionary on multiples lines. :)

> Also, complex syntax tends to be error-prone. One of the pain points of the
> current syntax is that many people forget to add : and =, or put modifiers
> in where expectations appear and vice versa.

I did that mistake myself, which is why I suggested a well known
syntax (it would also be easy to verify the syntax automatically if it
is easy).

That was just an example, I am not pushing for JSON in particular. I
am just in favor of something so simple you do not have to remember

In any case, I prefer your last suggestion over the first one.


More information about the webkit-dev mailing list