[webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Ryosuke Niwa rniwa at webkit.org
Wed May 16 23:04:36 PDT 2012

On Wed, May 16, 2012 at 10:37 PM, Benjamin Poulain <benjamin at webkit.org>wrote:

> On Wed, May 16, 2012 at 9:34 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
> I would go for something verbose in a easy to understand format. E.g.

{ test: 'fast/html/keygen.html',
>  platform: 'mac, linux',
>  bug: 'webkit.org/b/66666',
>  expectedResults: ['crash', 'text', 'image'],
>  action: 'skip' }

For the tests that need rebaseline or new results, I would leave them
> out of the file. I would use an second file, with entries sorted by bug
> number.
> I don't know all the problems related to test_expectations so that is
> just some ideas from what I encountered in the past.

As far as I know, a lot of people edit this file on a text editor so the
syntax needs be simple enough for that.

Also, complex syntax tends to be error-prone. One of the pain points of the
current syntax is that many people forget to add : and =, or put modifiers
in where expectations appear and vice versa.

- Rysouke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120516/cdd4ddda/attachment.html>

More information about the webkit-dev mailing list