[webkit-dev] Microdata document.getItems()

[Gurpreet Kaur]

Hi Arko,

Yes I am using older webkit version and have just merged the Microdata
patch. When I try to do alert(document.getItems()) via script  I get Object
NodeList but .lenght returns 0.
If possible Can you just explain how is the length calculated?

Regards,
Gurpreet

On Thu, Mar 8, 2012 at 2:20 PM, Arko Saha <nghq36 at motorola.com> wrote:

> Hi Gurpreet,
>
> Yes, document.getItems() takes an optional string "types" as the argument.
> It should return all microdata items in the document if the "types"
> argument is missing. I could see its working as expected in todays
> revision. Are you using latest Webkit revision?? If you are just merging
> microdata patches on some old webkit revision then I cannot help. In older
> revisions  please check the implementation of a existing method which
> allows optional argument.
>
> Thanks and Regards,
> Arko
>
>
> On Thu, Mar 8, 2012 at 1:49 PM, Gurpreet Kaur <gur.trio at gmail.com> wrote:
>
>> Hi Arko,
>>
>> On running the test case
>> http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/MicroData/002.html I
>> get the result as below.
>>
>> "
>> This test ensures that document.getItems().length must return the correct
>> number of MicroData Items in the Document.
>> Also it tests that document.getItems must return a live NodeList.
>>
>> *FAIL - expected 4 elements but got 0 elements.*
>> document.getItems() with empty string in the aurgument : PASS
>> document.getItems() with 'http://example.com/foo' itemtype in the
>> aurgument : PASS
>> document.getItems() with 'http://example.com/bar' itemtype in the
>> aurgument : PASS
>> document.getItems() with 'http://example.com/f1' itemtype in the
>> aurgument : PASS
>> Created element of type :  div
>> Set attribute:  itemscope,  value:  itemscope
>> *FAIL - expected 5 elements but got 0 elements.*
>> *FAIL - expected 4 elements but got 0 elements.*
>>
>> "
>>
>> document.getItems() should return all items and document.getItems(arg)
>> should return items which match the arg. Please correct me if I am wrong.
>>
>> Thanks and Regards,
>> Gurpreet
>>
>>
>> On Thu, Mar 8, 2012 at 1:36 PM, Arko Saha <nghq36 at motorola.com> wrote:
>>
>>> I tried to run the mentioned test cases in my local machine, its working
>>> fine. I have tested the same in latest Webkit revision (Chromium/GTK port).
>>> Not sure what could be the issue. Can you please attach the test failure
>>> diff here?
>>>
>>> Thanks and regards,
>>> Arko
>>>
>>>
>>> On Thu, Mar 8, 2012 at 1:29 PM, Gurpreet Kaur <gur.trio at gmail.com>wrote:
>>>
>>>> Dear Ryosuke,
>>>>
>>>> Thanks for the update.
>>>>
>>>> Dear Arko,
>>>>
>>>> Could you please help me with this?
>>>>
>>>> Thanks and Regards,
>>>> Gurpreet
>>>>
>>>>
>>>> On Thu, Mar 8, 2012 at 1:27 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>>>>
>>>>> Your best bet is to talk with Arko :)
>>>>>
>>>>> - Ryosuke
>>>>>
>>>>> On Wed, Mar 7, 2012 at 11:26 PM, Gurpreet Kaur <gur.trio at gmail.com>wrote:
>>>>>
>>>>>> Dear Webkit Team,
>>>>>>
>>>>>> I am working on Microdata for Android browser. After taking all the
>>>>>> changes related to Microdata the following test case is failing for me.
>>>>>>
>>>>>> http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/MicroData/002.html
>>>>>>
>>>>>> This test case has call to document.getItems() (with no arguments).
>>>>>> The call with arguments is working fine.
>>>>>>
>>>>>> Please update incase anyone have enabled the Microdata and tested
>>>>>> these layout test cases.
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Gurpreet
>>>>>>
>>>>>> _______________________________________________
>>>>>> webkit-dev mailing list
>>>>>> webkit-dev at lists.webkit.org
>>>>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120308/c2a87443/attachment.html>