[webkit-dev] Using commit-queue doesn't mean you can use build failures

[Hajime Morrita]

(from the right address...)
Hi,

I don't think it is a reasonable expectation especially for non-chromium
developers.

It is possible for a change to break chromium-linux, chromium-win or
chromium-mac,
that means developers needs to have Linux, Mac and Windows machines to
ensure
the successful build since there is no EWS for these configurations.

More reasonable baseline would be getting all EWS builds green
and/or watching the tree until landed patch goes green. And in my
understanding, these are in fact our current norm.

Regards,
--
morrita


On Thu, Jul 19, 2012 at 3:59 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:

> Hi all,
>
> Using commit-queue doesn't pardon a committer from causing build failures.
>
> Notice that the commit queue only builds & runs tests on Chromium Linux
> port. Thus, any build failure that doesn't manifest itself on Chromium
> Linux port — namely any JSC-specific or Windows/Mac specific build
> failures — won't be caught.
>
> The current policy specifically says the committer is responsible for
> making sure his or her patch builds & passes tests:
> http://www.webkit.org/coding/contributing.html
>
> So please make sure your patch at least builds if you're landing a patch
> via commit queue.
>
> Best,
> Ryosuke Niwa
> Software Engineer
> Google Inc.
>
>
>
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120719/3e08ed94/attachment.html>