[webkit-dev] Using commit-queue doesn't mean you can use build failures

Ryosuke Niwa rniwa at webkit.org
Wed Jul 18 23:59:41 PDT 2012


Hi all,

Using commit-queue doesn't pardon a committer from causing build failures.

Notice that the commit queue only builds & runs tests on Chromium Linux
port. Thus, any build failure that doesn't manifest itself on Chromium
Linux port — namely any JSC-specific or Windows/Mac specific build
failures — won't be caught.

The current policy specifically says the committer is responsible for
making sure his or her patch builds & passes tests:
http://www.webkit.org/coding/contributing.html

So please make sure your patch at least builds if you're landing a patch
via commit queue.

Best,
Ryosuke Niwa
Software Engineer
Google Inc.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20120718/b87a7d3f/attachment.html>


More information about the webkit-dev mailing list