[webkit-dev] Making PopupMenuClient testable

Darin Adler darin at apple.com
Mon Oct 10 14:11:31 PDT 2011


On Oct 10, 2011, at 7:57 AM, Fady Samuel wrote:

> My solution in 69631 is to expose the bounding box rect through the PopupMenuClient interface and make it testable through window.internals. I've also included a layout test to show how one would test this. Right now the test fails, but once 66062 is applied the test will pass.
> 
> Is this a reasonable approach?

This seems OK to me.

    -- Darin



More information about the webkit-dev mailing list