[webkit-dev] Making PopupMenuClient testable

Fady Samuel fsamuel at chromium.org
Mon Oct 10 14:08:57 PDT 2011


Hi Johnny,

>>> What I mean is regular render tree dump, not pixel dump, not text dump. Please refer here for test expectation and see in TestShell::dump in DRT chromium port

 I don't believe a render tree dump will solve this problem because
the issue is the rect that is being passed into the platform layer
doesn't take transforms into account.

>>> After landing https://bugs.webkit.org/show_bug.cgi?id=66062, will the PopupMenuClient take transforms into account?

Well, in particular, RenderMenuList will pass the appropriate
transformed rect of the PopupMenuCliient to the popup.

Fady


More information about the webkit-dev mailing list