[webkit-dev] Making PopupMenuClient testable

Fady Samuel fsamuel at chromium.org
Mon Oct 10 14:27:41 PDT 2011

Please review then? :-)


On Mon, Oct 10, 2011 at 9:11 PM, Darin Adler <darin at apple.com> wrote:
> On Oct 10, 2011, at 7:57 AM, Fady Samuel wrote:
>> My solution in 69631 is to expose the bounding box rect through the PopupMenuClient interface and make it testable through window.internals. I've also included a layout test to show how one would test this. Right now the test fails, but once 66062 is applied the test will pass.
>> Is this a reasonable approach?
> This seems OK to me.
>    -- Darin

More information about the webkit-dev mailing list