[webkit-dev] Done moving source files into Source

Adam Barth abarth at webkit.org
Mon Jan 17 04:12:05 PST 2011


On Mon, Jan 17, 2011 at 2:49 AM, Patrick Gansterer <paroga at paroga.com> wrote:
> Congratulation!
>
> Adam Barth:
>
>> If you own one of the files below, please consider moving it from the
>> root directory to the Source directory:
>>
>> cmakeconfig.h.cmake
>> CMakeLists.txt
>
> I'd like to move the CMake related files into Source, but they also require some files from the Tools directory (EWebLauncher, WinCELauncher).
> Maybe other build systems have the same problem.
>
> Can we move the code for the launchers into Sources too?

The launchers are clients of the WebKit API rather than part of WebKit
itself.  I'm not sure it makes sense to put them into the Source
directory.

> Otherwise we need to keep the files in the root directory. :-(

I'm not sure I understand the connection.  For example,
cmakeconfig.h.cmake seems to be entirely concerned with WebCore
concepts (essentially which features are enabled):

http://trac.webkit.org/browser/trunk/cmakeconfig.h.cmake

Surely the launchers don't need to peer into these internal details of WebCore.

Adam


More information about the webkit-dev mailing list