[webkit-dev] Review tool changes
kenneth.christiansen at openbossa.org
Fri Sep 17 04:37:57 PDT 2010
I just want to say that I absolutely love the new review tool and the
ability to select multiply lines of contents!
On Fri, Sep 17, 2010 at 4:11 AM, Darin Fisher <darin at chromium.org> wrote:
> On Fri, Sep 17, 2010 at 12:05 AM, Alexey Proskuryakov <ap at webkit.org> wrote:
>> 16.09.2010, в 23:39, Adam Barth написал(а):
>> > As mentioned above, the "publish" button actually brings up a
>> > confirmation screen. My original plan was to eventually remove the
>> > confirmation screen, since it's fully redundant, but I can leave it if
>> > folks find it useful.
>> It seems that for most easy reviews, the need to click twice will be a
>> nuisance once you know how the tool works. But for larger reviews, having a
>> look at the final text can be beneficial (just like you look over a patch
>> just before uploading it).
> Yes, this describes my current experience with the tool. If I set the
> review flag to r+ and have made no comments on the patch, then I'd like a
> button to press that will just submit my r+ without any preview or further
> confirmation step.
> That said, this is just a small nit-pick. Personally, I find the existing
> tool to be a vast improvement already over what we had before.
>> >> One thing I'd love to see added is a back-link to a bug. I find myself
>> >> using that fairly often currently.
>> > A couple other folks requested this as well. The complication here is
>> > that navigating away from the tool will lose your in-progress edits.
>> I only want this in order to open the bug in a new tab, so a _blank target
>> would sidestep the problem.
>> - WBR, Alexey Proskuryakov
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
Kenneth Rohde Christiansen
Technical Lead / Senior Software Engineer
Qt Labs Americas, Nokia Technology Institute, INdT
Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org
More information about the webkit-dev