[webkit-dev] Ancient patches in pending-review

David Levin levin at google.com
Thu May 13 10:19:03 PDT 2010


On Thu, May 13, 2010 at 10:15 AM, Alexey Proskuryakov <ap at webkit.org> wrote:

>
> 13.05.2010, в 9:41, David Levin написал(а):
>
>
>  * 35573: WebSocket add new event: CloseEvent
>>
>> I think ap is much more familiar with WebSockets -- though I am willing to
>> look if needed.
>>
>
> Anyone can review this patch - the key to reviewing is to decide whether a
> "close event" actually makes sense. A reviewer would want to read relevant
> parts of WebSocket spec, and to understand TCP state diagram well. I've been
> hesitant to review, hoping for possible conceptual issues to be resolved in
> IETF spec review first.
>

Should we just r- and ask that it wait for "conceptual issues to be resolved
in IETF spec review first" (unless for some reason it is needed quickly and
that takes too long)?


> - WBR, Alexey Proskuryakov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100513/9d60b6aa/attachment.html>


More information about the webkit-dev mailing list