[webkit-dev] Remove underscore check in check-webkit-style?

[David Levin]

3) Stop checking code in gtk/qt platform directories for underscores?

I think there are several other checks that code in some of these
directories typically fail due to various issues (public api that should
follow the standard public api format for that platform, etc.)


On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth <abarth at webkit.org> wrote:

> Current check-webkit-style and the style bot complain if code uses
> identifiers with underscores in their names.  It turns out our code
> does this fairly often, especially in Qt and Gtk specific code, for
> example to interface with unit testing frameworks.  We could either:
>
> 1) Teach check-webkit-style about these cases
> 2) Remove the underscore check entirely
>
> My inclination is to do (2) because I haven't seen this check find
> many actual style problems.  However, if we think that (1) is the
> better road, I'll be happy to make that happen.
>
> Adam
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100113/44a6dea7/attachment.html>