[webkit-dev] Remove underscore check in check-webkit-style?

Evan Martin evan at chromium.org
Wed Jan 13 16:17:21 PST 2010

On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth <abarth at webkit.org> wrote:
> Current check-webkit-style and the style bot complain if code uses
> identifiers with underscores in their names.  It turns out our code
> does this fairly often, especially in Qt and Gtk specific code, for
> example to interface with unit testing frameworks.  We could either:
> 1) Teach check-webkit-style about these cases
> 2) Remove the underscore check entirely
> My inclination is to do (2) because I haven't seen this check find
> many actual style problems.  However, if we think that (1) is the
> better road, I'll be happy to make that happen.

I frequently forget the underscore rule (since all the other code I
work on prefers underscores).  As a beneficiary of the style checker,
I'd prefer to avoid (2) if possible.

More information about the webkit-dev mailing list