[webkit-dev] [webkit-changes] [55234] trunk/JavaScriptCore

[Jochen Eisinger]

Here's a bit of context. When a database is opened, right now you
don't have any context from where it is opened. The problem is that
the actual calls that open a database go through the sqlite3 vfs
layer, so there's no easy way to pass this function down to to
platform/sql/chromium/SQLFileSystemChromium*.cpp

This patch will allow you to get from anywhere within webkit a pointer
to the Thread object that actually created the thread you're currently
on (in case of the database, this can be either a thread forked of
from the main thread or from a worker thread), and query the object
for context information.

I hope this explains this.

best
-jochen

On Thu, Feb 25, 2010 at 6:31 PM, Alexey Proskuryakov <ap at webkit.org> wrote:
>
> There is not a single word explaining this change - neither in ChangeLog,
> nor in the bug. Such a patch shouldn't have been accepted. Is there any
> reason not to roll it out?
> - WBR, Alexey Proskuryakov
> On 25.02.2010, at 6:49, eric at webkit.org wrote:
>
> Revision55234Authoreric at webkit.orgDate2010-02-25 06:49:12 -0800 (Thu, 25 Feb
> 2010)
>
> Log Message
>
> 2010-02-25  Jochen Eisinger  <jochen at chromium.org>
>
>         Reviewed by Jeremy Orlow.
>
>         Make the context that was passed to the ThreadFunction accessible.
>         https://bugs.webkit.org/show_bug.cgi?id=35379
>
>         * wtf/Threading.h:
>         * wtf/ThreadingNone.cpp:
>         (WTF::threadContext):
>         * wtf/ThreadingPthreads.cpp:
>         (WTF::):
>         (WTF::identifierByPthreadHandle):
>         (WTF::establishIdentifierForPthreadHandle):
>         (WTF::pthreadHandleForIdentifier):
>         (WTF::contextForIdentifier):
>         (WTF::createThreadInternal):
>         (WTF::currentThread):
>         (WTF::threadContext):
>         * wtf/ThreadingWin.cpp:
>         (WTF::):
>         (WTF::threadMap):
>         (WTF::storeThreadHandleByIdentifier):
>         (WTF::threadHandleForIdentifier):
>         (WTF::contextForIdentifier):
>         (WTF::createThreadInternal):
>         (WTF::threadContext):
>
>