[webkit-dev] [webkit-changes] [55234] trunk/JavaScriptCore

[David Levin]

Often when I have to understand the history of code, I look back at
changelog's/commit messages to understand why a change was done.

All the information being provided now explains the why. Unfortunately, this
thread doesn't fix the problem that the ChangeLog as checked in only
explains "*what*" as opposed to "*why*" (even fixing the ChangeLog will
leave it disconnected from the code change, but simply rolling it out and
then checking it again with a good changelog would fix this).

dave

On Thu, Feb 25, 2010 at 9:48 AM, Jochen Eisinger <jochen at chromium.org>wrote:

> Here's a bit of context. When a database is opened, right now you
> don't have any context from where it is opened. The problem is that
> the actual calls that open a database go through the sqlite3 vfs
> layer, so there's no easy way to pass this function down to to
> platform/sql/chromium/SQLFileSystemChromium*.cpp
>
> This patch will allow you to get from anywhere within webkit a pointer
> to the Thread object that actually created the thread you're currently
> on (in case of the database, this can be either a thread forked of
> from the main thread or from a worker thread), and query the object
> for context information.
>
> I hope this explains this.
>
> best
> -jochen
>
> On Thu, Feb 25, 2010 at 6:31 PM, Alexey Proskuryakov <ap at webkit.org>
> wrote:
> >
> > There is not a single word explaining this change - neither in ChangeLog,
> > nor in the bug. Such a patch shouldn't have been accepted. Is there any
> > reason not to roll it out?
> > - WBR, Alexey Proskuryakov
> > On 25.02.2010, at 6:49, eric at webkit.org wrote:
> >
> > Revision55234Authoreric at webkit.orgDate2010-02-25 06:49:12 -0800 (Thu, 25
> Feb
> > 2010)
> >
> > Log Message
> >
> > 2010-02-25  Jochen Eisinger  <jochen at chromium.org>
> >
> >         Reviewed by Jeremy Orlow.
> >
> >         Make the context that was passed to the ThreadFunction
> accessible.
> >         https://bugs.webkit.org/show_bug.cgi?id=35379
> >
> >         * wtf/Threading.h:
> >         * wtf/ThreadingNone.cpp:
> >         (WTF::threadContext):
> >         * wtf/ThreadingPthreads.cpp:
> >         (WTF::):
> >         (WTF::identifierByPthreadHandle):
> >         (WTF::establishIdentifierForPthreadHandle):
> >         (WTF::pthreadHandleForIdentifier):
> >         (WTF::contextForIdentifier):
> >         (WTF::createThreadInternal):
> >         (WTF::currentThread):
> >         (WTF::threadContext):
> >         * wtf/ThreadingWin.cpp:
> >         (WTF::):
> >         (WTF::threadMap):
> >         (WTF::storeThreadHandleByIdentifier):
> >         (WTF::threadHandleForIdentifier):
> >         (WTF::contextForIdentifier):
> >         (WTF::createThreadInternal):
> >         (WTF::threadContext):
> >
> >
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100225/77bb4dc9/attachment.html>