[webkit-dev] [webkit-changes] [55234] trunk/JavaScriptCore

[Jeremy Orlow]

I assume a subsequent patch is going to take advantage of this information.
 It's a relatively simple change that's simply exposing the existing void*
of context that's available in pretty much every threading library.  Is
there any specific reason we don't want to use this information documented
somewhere that I missed?

I guess I could have asked to see the subsequent patch that would utilize
this change before r+ing it and/or asked for more context publicly, but I
knew where he was going with this: making it possible for us to know which
database is associated with a particular thread when the SQLite VFS layer is
trying to open a file.  We need this information in connection to content
blocking (and asking) code we're building into Chromium.

I'm sorry if this should have been better made part of public record, but I
don't think I did anything too out of character for WebKit development.  The
ChangeLog was to the point and described the specific change.  Jochen and I
had talked about some of these changes on IM, in private email, and on our
bug tracker (much like you guys talk in person and in Radar about the bigger
picture in many cases).

Also, I'm not really sure why this required a webkit-dev thread.  I've been
on IRC all morning.

On Thu, Feb 25, 2010 at 6:31 PM, Alexey Proskuryakov <ap at webkit.org> wrote:

>
> There is not a single word explaining this change - neither in ChangeLog,
> nor in the bug. Such a patch shouldn't have been accepted. Is there any
> reason not to roll it out?
>
> - WBR, Alexey Proskuryakov
>
> On 25.02.2010, at 6:49, eric at webkit.org wrote:
>
>  Revision55234 <http://trac.webkit.org/projects/webkit/changeset/55234>
> Authoreric at webkit.org Date2010-02-25 06:49:12 -0800 (Thu, 25 Feb 2010) Log
> Message
>
>
> 2010-02-25  Jochen Eisinger  <jochen at chromium.org>
>
>         Reviewed by Jeremy Orlow.
>
>         Make the context that was passed to the ThreadFunction accessible.
>         https://bugs.webkit.org/show_bug.cgi?id=35379
>
>         * wtf/Threading.h:
>         * wtf/ThreadingNone.cpp:
>         (WTF::threadContext):
>         * wtf/ThreadingPthreads.cpp:
>         (WTF::):
>         (WTF::identifierByPthreadHandle):
>         (WTF::establishIdentifierForPthreadHandle):
>         (WTF::pthreadHandleForIdentifier):
>         (WTF::contextForIdentifier):
>         (WTF::createThreadInternal):
>         (WTF::currentThread):
>         (WTF::threadContext):
>         * wtf/ThreadingWin.cpp:
>         (WTF::):
>         (WTF::threadMap):
>         (WTF::storeThreadHandleByIdentifier):
>         (WTF::threadHandleForIdentifier):
>         (WTF::contextForIdentifier):
>         (WTF::createThreadInternal):
>         (WTF::threadContext):
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20100225/7009f9f0/attachment.html>